Remove Formspree and secure Wren API token
Some checks failed
Build and Push Docker Images / docker (push) Failing after 1m54s
Some checks failed
Build and Push Docker Images / docker (push) Failing after 1m54s
Security & Cleanup Changes: 1. Removed NEXT_PUBLIC_WREN_API_TOKEN from frontend (security risk) 2. Removed Formspree references (no longer needed) 3. Wren API token now lives in backend only (runtime configurable) 4. Added NocoDB env vars to frontend for admin portal server-side API Changes: - Dockerfile: Removed Formspree and NEXT_PUBLIC_WREN_API_TOKEN build args - CI/CD: Updated build-args to only include necessary variables - Frontend should call backend /api/wren/* endpoints - Backend handles Wren API with WREN_API_TOKEN (can change anytime!) Benefits: ✅ API token no longer exposed in browser ✅ Can change Wren token without rebuilding images ✅ Cleaner build process ✅ Removed unused Formspree dependencies 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
parent
bfe5897232
commit
bfb163c21a
@ -32,9 +32,6 @@ jobs:
|
|||||||
push: true
|
push: true
|
||||||
build-args: |
|
build-args: |
|
||||||
NEXT_PUBLIC_API_BASE_URL=${{ vars.NEXT_PUBLIC_API_BASE_URL }}
|
NEXT_PUBLIC_API_BASE_URL=${{ vars.NEXT_PUBLIC_API_BASE_URL }}
|
||||||
NEXT_PUBLIC_WREN_API_TOKEN=${{ secrets.NEXT_PUBLIC_WREN_API_TOKEN }}
|
|
||||||
NEXT_PUBLIC_FORMSPREE_CONTACT_ID=${{ secrets.NEXT_PUBLIC_FORMSPREE_CONTACT_ID }}
|
|
||||||
NEXT_PUBLIC_FORMSPREE_OFFSET_ID=${{ secrets.NEXT_PUBLIC_FORMSPREE_OFFSET_ID }}
|
|
||||||
NEXT_PUBLIC_STRIPE_PUBLISHABLE_KEY=${{ secrets.NEXT_PUBLIC_STRIPE_PUBLISHABLE_KEY }}
|
NEXT_PUBLIC_STRIPE_PUBLISHABLE_KEY=${{ secrets.NEXT_PUBLIC_STRIPE_PUBLISHABLE_KEY }}
|
||||||
tags: |
|
tags: |
|
||||||
${{ vars.REGISTRY_HOST }}/${{ vars.REGISTRY_USERNAME }}/${{ vars.IMAGE_NAME }}:frontend-latest
|
${{ vars.REGISTRY_HOST }}/${{ vars.REGISTRY_USERNAME }}/${{ vars.IMAGE_NAME }}:frontend-latest
|
||||||
|
|||||||
@ -13,16 +13,10 @@ COPY . .
|
|||||||
# Accept build arguments for NEXT_PUBLIC_ variables
|
# Accept build arguments for NEXT_PUBLIC_ variables
|
||||||
# These MUST be provided at build time
|
# These MUST be provided at build time
|
||||||
ARG NEXT_PUBLIC_API_BASE_URL
|
ARG NEXT_PUBLIC_API_BASE_URL
|
||||||
ARG NEXT_PUBLIC_WREN_API_TOKEN
|
|
||||||
ARG NEXT_PUBLIC_FORMSPREE_CONTACT_ID
|
|
||||||
ARG NEXT_PUBLIC_FORMSPREE_OFFSET_ID
|
|
||||||
ARG NEXT_PUBLIC_STRIPE_PUBLISHABLE_KEY
|
ARG NEXT_PUBLIC_STRIPE_PUBLISHABLE_KEY
|
||||||
|
|
||||||
# Set as environment variables so Next.js can bake them into the build
|
# Set as environment variables so Next.js can bake them into the build
|
||||||
ENV NEXT_PUBLIC_API_BASE_URL=$NEXT_PUBLIC_API_BASE_URL
|
ENV NEXT_PUBLIC_API_BASE_URL=$NEXT_PUBLIC_API_BASE_URL
|
||||||
ENV NEXT_PUBLIC_WREN_API_TOKEN=$NEXT_PUBLIC_WREN_API_TOKEN
|
|
||||||
ENV NEXT_PUBLIC_FORMSPREE_CONTACT_ID=$NEXT_PUBLIC_FORMSPREE_CONTACT_ID
|
|
||||||
ENV NEXT_PUBLIC_FORMSPREE_OFFSET_ID=$NEXT_PUBLIC_FORMSPREE_OFFSET_ID
|
|
||||||
ENV NEXT_PUBLIC_STRIPE_PUBLISHABLE_KEY=$NEXT_PUBLIC_STRIPE_PUBLISHABLE_KEY
|
ENV NEXT_PUBLIC_STRIPE_PUBLISHABLE_KEY=$NEXT_PUBLIC_STRIPE_PUBLISHABLE_KEY
|
||||||
|
|
||||||
# Build Next.js app (standalone mode)
|
# Build Next.js app (standalone mode)
|
||||||
|
|||||||
Loading…
x
Reference in New Issue
Block a user